Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug of output dimension in pt InvarFitting #3274

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

wanghan-iapcm
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@anyangml anyangml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we simply use dim_out, instead of creating another variable?

@wanghan-iapcm
Copy link
Collaborator Author

can we simply use dim_out, instead of creating another variable?

sure

@wanghan-iapcm
Copy link
Collaborator Author

can we simply use dim_out, instead of creating another variable?

introduced to align with in_dim :)

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25bf37a) 74.91% compared to head (cc7d8b0) 74.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3274      +/-   ##
==========================================
- Coverage   74.91%   74.91%   -0.01%     
==========================================
  Files         378      378              
  Lines       33426    33425       -1     
  Branches     1600     1604       +4     
==========================================
- Hits        25041    25040       -1     
  Misses       7514     7514              
  Partials      871      871              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm enabled auto-merge (squash) February 14, 2024 14:25
@wanghan-iapcm wanghan-iapcm merged commit 097b3ab into deepmodeling:devel Feb 14, 2024
46 checks passed
@njzjz njzjz mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants